RTC: Remove post list lock icon and replace user-specific lock text when RTC is enabled#11234
RTC: Remove post list lock icon and replace user-specific lock text when RTC is enabled#11234maxschmeling wants to merge 12 commits intoWordPress:trunkfrom
Conversation
…dicator when RTC is enabled.
When real-time collaboration is enabled, the post list no longer shows exclusive
lock semantics (padlock icon, user avatar, "{user} is currently editing") since
multiple users can collaboratively edit the same post. Instead:
- Shows generic "Currently being edited" text without user-specific info.
- Uses `wp-collaborative-editing` CSS class instead of `wp-locked`, which
preserves checkbox and row action visibility (no exclusive lock restrictions).
- Changes the "Edit" row action text to "Join" for locked posts.
- Heartbeat responses send generic text with a `collaborative` flag.
- Injects `_wpCollaborationEnabled` into `inline-edit-post` script so the
heartbeat JS handler applies the correct class on dynamic lock updates.
When RTC is disabled, classic lock behavior is completely unchanged.
Backports WordPress/gutenberg#76322 to core.
Props pkevan.
See #75313.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
maxschmeling
changed the title
Co-authored-by: Chris Zarate <chris@zarate.org>
|
I tried testing it locally and I can still see the post lock modal. |
Updating the branch fixed it. It was related to change in option name in #11289 |
|
Looks good to me, approved 🚢 |
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
Please note that my cursory review only considered i18n.
Thanks, @maxschmeling, I've commented on one thing, but everything else looks good |
maxschmeling
changed the title
…specific lock text when RTC is enabled. When RTC is enabled, the post list should not show an exclusive lock icon or user-specific lock text since multiple users can collaboratively edit the same post. Merges a fix from Gutenberg: WordPress/gutenberg#76322. Developed in: #11234. See #64622. Props maxschmeling, czarate, mcsf, shekharnwagh. git-svn-id: https://develop.svn.wordpress.org/trunk@62074 602fd350-edb4-49c9-b593-d223f7449a82
…specific lock text when RTC is enabled. When RTC is enabled, the post list should not show an exclusive lock icon or user-specific lock text since multiple users can collaboratively edit the same post. Merges a fix from Gutenberg: WordPress/gutenberg#76322. Developed in: WordPress/wordpress-develop#11234. See #64622. Props maxschmeling, czarate, mcsf, shekharnwagh. Built from https://develop.svn.wordpress.org/trunk@62074 git-svn-id: http://core.svn.wordpress.org/trunk@61356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
This is committed |
5 participants
Backport WordPress/gutenberg#76322.
When RTC is enabled, the post list should not show an exclusive lock icon or user-specific lock text since multiple users can collaboratively edit the same post.
Trac ticket: https://core.trac.wordpress.org/ticket/64622